Skip to content

fix: assume current year for formats without it#1288

Merged
Gallaecio merged 6 commits intoscrapinghub:masterfrom
NTFSvolume:fix_dates_no_year
Oct 28, 2025
Merged

fix: assume current year for formats without it#1288
Gallaecio merged 6 commits intoscrapinghub:masterfrom
NTFSvolume:fix_dates_no_year

Conversation

@NTFSvolume
Copy link
Copy Markdown
Contributor

@NTFSvolume NTFSvolume commented Oct 26, 2025 •
edited
Loading

@NTFSvolume NTFSvolume changed the title fix: asume current year for formats without it fix: assume current year for formats without it Oct 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.60%. Comparing base (bdc57d3) to head (648a0f7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
+ Coverage   96.58%   96.60%   +0.02%     
==========================================
  Files         235      235              
  Lines        2866     2886      +20     
==========================================
+ Hits         2768     2788      +20     
  Misses         98       98

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gallaecio
Copy link
Copy Markdown
Contributor

Gallaecio commented Oct 27, 2025

Seems like you need a minor change for Python 3.10 support in tests.

@Gallaecio Gallaecio mentioned this pull request Oct 27, 2025
Closed
BoboTiG
BoboTiG reviewed Oct 27, 2025
View reviewed changes
tests/test_utils_strptime.py

@parameterized.expand(
[
param(date_string="oct 14", fmt=r"%m %d"),
Copy link
Copy Markdown

@BoboTiG BoboTiG Oct 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding more cases here? Like "14-October-2025" which also triggers the warning on my side; and at least the original test case from the issue: "2024-11-27"?

Copy link
Copy Markdown
Contributor Author

@NTFSvolume NTFSvolume Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I added them to the parser tests

@NTFSvolume
Copy link
Copy Markdown
Contributor Author

NTFSvolume commented Oct 27, 2025

Fixed compat issues with python 3.9/3.10 and added some additional tests

@BoboTiG
Copy link
Copy Markdown

BoboTiG commented Oct 27, 2025

Works for me, thanks @NTFSvolume 🥂

@Gallaecio Gallaecio merged commit b7bb1a5 into scrapinghub:master Oct 28, 2025
15 checks passed
@Gallaecio
Copy link
Copy Markdown
Contributor

Gallaecio commented Oct 28, 2025

Thanks!

@NTFSvolume NTFSvolume deleted the fix_dates_no_year branch October 28, 2025 17:41
@Mariatta
Copy link
Copy Markdown

Mariatta commented Feb 3, 2026

Could we please get a release that includes this fix?
Thank you.

@Gallaecio
Copy link
Copy Markdown
Contributor

Gallaecio commented Feb 4, 2026

https://github.com/scrapinghub/dateparser/releases/tag/v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@BoboTiG BoboTiG BoboTiG left review comments

@Gallaecio Gallaecio Gallaecio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeprecationWarning: Parsing dates involving a day of month without a year specified is ambiguious

4 participants

@NTFSvolume @Gallaecio @BoboTiG @Mariatta