Conversation
Member
|
Please check https://github.com/scrapinghub/dateparser/blob/master/CONTRIBUTING.rst#guidelines-for-editing-translation-data about editing language data (you edited a generated file). |
1e4c73c to
30e2c7f
Compare
- Update en.yaml file to support two letters days of the week - #1170
Contributor
|
Any idea about the failing test? |
- Develop method to remove_multiple_occurrences of the day(s) of the week - #1170
Gallaecio
reviewed
Jan 30, 2024
Contributor
|
Could you add tests for the fix itself? (7 dates with the short weekday form that are properly parsed) I think that’s all that’s left. |
- Add tests - #1170
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1214 +/- ##
=======================================
Coverage 96.60% 96.60%
=======================================
Files 235 235
Lines 2886 2889 +3
=======================================
+ Hits 2788 2791 +3
Misses 98 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gallaecio
reviewed
Aug 12, 2025
Gallaecio
reviewed
Aug 12, 2025
Gallaecio
reviewed
Aug 12, 2025
- improve the tokenization to handle suffixes like "th", "st", "nd", "rd" attached to numbers - remove remove_multiple_occurrences this method - fix tests to use the current year instead of 2025 - #1170
Gallaecio
reviewed
Jan 7, 2026
dateparser_data/supplementary_language_data/date_translation_data/en.yaml
Outdated
Show resolved
Hide resolved
Gallaecio
reviewed
Jan 7, 2026
Gallaecio
reviewed
Jan 7, 2026
Gallaecio
reviewed
Jan 7, 2026
- remove unused code. - #1170
Gallaecio
approved these changes
Jan 8, 2026
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1170