support two-digit year in non-gregorian calendars#1187
Merged
Gallaecio merged 2 commits intoscrapinghub:masterfrom Nov 22, 2023
Merged
support two-digit year in non-gregorian calendars#1187Gallaecio merged 2 commits intoscrapinghub:masterfrom
Gallaecio merged 2 commits intoscrapinghub:masterfrom
Conversation
Gallaecio
approved these changes
Sep 26, 2023
Contributor
Gallaecio
left a comment
There was a problem hiding this comment.
Nice.
I wonder if we should do something similar for Gregorian, but no need to do it here.
Contributor
Author
|
The primary advantage of this approach over the Gregorian one is its customizability. Everyone can easily extend the parsers and override the |
Contributor
Author
|
@Gallaecio This PR has been approved but not merged yet. Could you check this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had an issue with parsing two digit year in non-gregorian calendars. This PR will fix that issue and provide a fix for both jalali and hijri calendars.