Use timezone via settings to get PREFER_DATES_FROM result#1155
Merged
serhii73 merged 3 commits intoscrapinghub:masterfrom Mar 22, 2023
Merged
Use timezone via settings to get PREFER_DATES_FROM result#1155serhii73 merged 3 commits intoscrapinghub:masterfrom
serhii73 merged 3 commits intoscrapinghub:masterfrom
Conversation
Gallaecio
reviewed
Mar 21, 2023
This ensures that we are still processing times such as EDT or AEDT which returns UnknownTimezoneError with pytz.timezone method.
Contributor
|
I have run the minimum working example from the original report, and the output is the same before and after this change. |
Collaborator
Author
|
The test cases would fail on the master branch. Also, for me, the changes result in the correct output. |
Contributor
|
You are right, I am getting the expected output with the fix now. I have no idea what I did wrong before, I must have installed the wrong branch 😅 |
Gallaecio
approved these changes
Mar 22, 2023
Contributor
|
Today I Learn |
Gallaecio
approved these changes
Mar 22, 2023
serhii73
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1092