Merged
Conversation
wRAR
approved these changes
Mar 4, 2023
Gallaecio
approved these changes
Mar 7, 2023
Contributor
|
If you don't mind, I'm wondering why does the modification in this PR are done directly in CLDR JSON file? From what I understand, those CLDR files are synced periodically with the upstream repo,so it shouldn't be modified. Instead, we should modify the supplemental Is my understanding correct? Or have there been recent changes to the way translations are contributed? |
Contributor
|
You are right, we should only be modifying YAML files. @serhii73 It is probably OK for now, but whenever we update the CLDR JSON files from upstream next, we may need to check if what we added here exists upstream, and if not, we would need to move the data to the YAML files to make sure it is included going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.