Skip to content

Update zh data#1148

Merged
Gallaecio merged 1 commit intomasterfrom
add/zh-terms
Mar 7, 2023
Merged

Update zh data#1148
Gallaecio merged 1 commit intomasterfrom
add/zh-terms

Conversation

@serhii73
Copy link
Copy Markdown
Collaborator

@serhii73 serhii73 commented Mar 3, 2023

No description provided.

@Gallaecio Gallaecio merged commit 7cd3b80 into master Mar 7, 2023
@RadhiFadlillah
Copy link
Copy Markdown
Contributor

If you don't mind, I'm wondering why does the modification in this PR are done directly in CLDR JSON file?

From what I understand, those CLDR files are synced periodically with the upstream repo,so it shouldn't be modified. Instead, we should modify the supplemental *.yaml file which later will be merged with the CLDR data.

Is my understanding correct? Or have there been recent changes to the way translations are contributed?

@Gallaecio
Copy link
Copy Markdown
Contributor

You are right, we should only be modifying YAML files.

@serhii73 It is probably OK for now, but whenever we update the CLDR JSON files from upstream next, we may need to check if what we added here exists upstream, and if not, we would need to move the data to the YAML files to make sure it is included going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants