fix leak of memory in cache - add settings.CACHE_SIZE_LIMIT#1140
Merged
serhii73 merged 1 commit intoscrapinghub:masterfrom Mar 15, 2023
Merged
fix leak of memory in cache - add settings.CACHE_SIZE_LIMIT#1140serhii73 merged 1 commit intoscrapinghub:masterfrom
serhii73 merged 1 commit intoscrapinghub:masterfrom
Conversation
Gallaecio
approved these changes
Mar 15, 2023
Contributor
Gallaecio
left a comment
There was a problem hiding this comment.
I wonder if something like cachetools.LRUCache would be a better choice here, but this seems like an improvement nonetheless.
serhii73
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROBLEM: leak of memory.
After each calling of
dateparser.parsenew item is added to cache dictionaries:After 3000 calls we will found 3000 items in each of dictionaries, and we have lost few memory. We are forced to stop using this module.
SOLUTION: add a limit (
CACHE_SIZE_LIMIT) for max items in caches.