Skip to content

Add 'ago' to french relative parsing#1110

Merged
Gallaecio merged 1 commit intoscrapinghub:masterfrom
gutsytechster:add_ago_to_french_parser-1102
Dec 29, 2022
Merged

Add 'ago' to french relative parsing#1110
Gallaecio merged 1 commit intoscrapinghub:masterfrom
gutsytechster:add_ago_to_french_parser-1102

Conversation

@gutsytechster
Copy link
Copy Markdown
Collaborator

@gutsytechster gutsytechster commented Dec 16, 2022

This fixes #1102

@gutsytechster gutsytechster force-pushed the add_ago_to_french_parser-1102 branch from 1c97d3d to 6d3f42e Compare December 16, 2022 16:30
@serhii73 serhii73 requested review from serhii73 and wRAR December 16, 2022 21:20
@wRAR
Copy link
Copy Markdown
Member

wRAR commented Dec 17, 2022

Does French really use the English word "ago" in the same way English uses it? I can't find anything that proves it.

@serhii73 serhii73 self-requested a review December 19, 2022 11:29
@serhii73
Copy link
Copy Markdown
Collaborator

serhii73 commented Dec 19, 2022

Looks like you're right @wRAR
Can you please check @gutsytechster this link: https://www.interglot.com/dictionary/fr/fr/translate/il%20y%20a
Thanks in advance.

@Gallaecio Gallaecio mentioned this pull request Dec 19, 2022
Closed
@gutsytechster
Copy link
Copy Markdown
Collaborator Author

gutsytechster commented Dec 20, 2022

I understood from the initial issue that the English word ago is used along with the French word. I also checked the dictionary with @serhii73 mentioned in the above message, and I don't see any french word ago in that. So it shouldn't have any other meaning besides the English meaning.

@serhii73
Copy link
Copy Markdown
Collaborator

serhii73 commented Dec 21, 2022

I guess it makes sence just add a test for:

from dateparser import parse

parse('4 heures ago')

>> None

And don't add ago to French. What do you think, guys?

@wRAR
Copy link
Copy Markdown
Member

wRAR commented Dec 28, 2022

Yeah.

@gutsytechster
tests(test_freshness_date_parser.py): add test case for french + engl…
ef23f4b 
…ish string

The parser shouldn't scrape such a case.
@gutsytechster gutsytechster force-pushed the add_ago_to_french_parser-1102 branch from 6d3f42e to ef23f4b Compare December 29, 2022 12:40
@Gallaecio Gallaecio merged commit d28fd0d into scrapinghub:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhii73 serhii73 serhii73 approved these changes

@wRAR wRAR Awaiting requested review from wRAR

+1 more reviewer

@Gallaecio Gallaecio Gallaecio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

French issue

4 participants

@gutsytechster @wRAR @serhii73 @Gallaecio