Merged
Conversation
tests for suplementary data
# Conflicts: # dateparser/data/date_translation_data/sk.py
Contributor
Author
|
Hi I merged the latest changes and updated mine according to them. It would be great if somebody take take a look at this PR. Thanks. |
Gallaecio
approved these changes
Nov 8, 2022
wRAR
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main aim is to cover shorthand relative dates when relating to "one". Similar to English, where 'a' is used, Slovak leaves out the slot entirely. So relative date 'o hodinu' means 'in an hour', which was not working. But 'o 1 hodinu' was working, this is rarely used in Slovak however.
Also added forms of words used with count 2,3,4 - e.g. in 2 weeks -> o 2 týždne, but in 5 weeks -> o 5 týždňov. This is sometimes referred as "one, few, many" grouping, where English only uses one and many.