Skip to content

Added Support for relative dates with full words of month and year in Indonesian Language#1003

Closed
atharmohammad wants to merge 3 commits intoscrapinghub:masterfrom
atharmohammad:issue/912-rel-dates-err-ind
Closed

Added Support for relative dates with full words of month and year in Indonesian Language#1003
atharmohammad wants to merge 3 commits intoscrapinghub:masterfrom
atharmohammad:issue/912-rel-dates-err-ind

Conversation

@atharmohammad
Copy link
Copy Markdown
Contributor

Closes #912

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2021

Codecov Report

Base: 98.23% // Head: 98.30% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (6a74fe6) compared to base (bcd1a3c).
Patch has no changes to coverable lines.

❗ Current head 6a74fe6 differs from pull request most recent head 0777e7c. Consider uploading reports for the commit 0777e7c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   98.23%   98.30%   +0.07%     
==========================================
  Files         232      234       +2     
  Lines        2605     2899     +294     
==========================================
+ Hits         2559     2850     +291     
- Misses         46       49       +3     
Impacted Files Coverage Δ
dateparser/data/date_translation_data/id.py 100.00% <ø> (ø)
dateparser/utils/__init__.py 93.45% <0.00%> (-1.83%) ⬇️
dateparser/languages/locale.py 98.69% <0.00%> (-0.01%) ⬇️
dateparser/conf.py 100.00% <0.00%> (ø)
dateparser/__init__.py 100.00% <0.00%> (ø)
dateparser/date.py 99.47% <0.00%> (+0.19%) ⬆️
dateparser/parser.py 99.31% <0.00%> (+0.29%) ⬆️
dateparser/date_parser.py 97.72% <0.00%> (+3.78%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@serhii73 serhii73 closed this Oct 31, 2022
@serhii73 serhii73 reopened this Oct 31, 2022
@serhii73 serhii73 requested review from serhii73 and wRAR November 3, 2022 07:37
@wRAR
Copy link
Copy Markdown
Member

wRAR commented Nov 3, 2022

AssertionError: The content of the file "../dateparser/data/date_translation_data/id.py" doesn't match the content of the generated file.

@serhii73
Copy link
Copy Markdown
Collaborator

I close this issue after merging this PR

Thank you.

@serhii73 serhii73 closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing relative dates error with Indonesian

4 participants