Skip to content

Fix #403#1002

Merged
Gallaecio merged 3 commits intoscrapinghub:masterfrom
Baviaan:datetime-skips-day
Oct 21, 2022
Merged

Fix #403#1002
Gallaecio merged 3 commits intoscrapinghub:masterfrom
Baviaan:datetime-skips-day

Conversation

@Baviaan
Copy link
Copy Markdown
Contributor

@Baviaan Baviaan commented Oct 19, 2021

The parse function only works with naive times, so this provides timezone information to compute the offset from utc and provide _correct_for_time_frame with the utc time instead of local time as _correct_for_time_frame checks if the time has passed in utc.

This fixes #403

Gallaecio
Gallaecio reviewed Oct 19, 2021
View reviewed changes
@Gallaecio
Copy link
Copy Markdown
Contributor

Gallaecio commented Oct 19, 2021

Could you please include a test for the fix?

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #1002 (50c3872) into master (8af4f29) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         234      234           
  Lines        2694     2697    +3     
=======================================
+ Hits         2648     2651    +3     
  Misses         46       46
Impacted Files Coverage Δ
dateparser/date_parser.py 93.75% <100.00%> (ø)
dateparser/parser.py 99.01% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af4f29...50c3872. Read the comment docs.

@Baviaan
Copy link
Copy Markdown
Contributor Author

Baviaan commented Oct 19, 2021

Thanks for the comments.

  • I have renamed ptz to tz.
  • I passed tz to _correct_for_time_frame to do the shift inside the method. (This looks much better indeed!)
  • I have added two tests that fail on master but pass with these fixes. (One for 'future' and for 'past' prefer_dates_from setting.) I wasn't sure where to put them, they're currently at the bottom of the test_date_parser.py file.

@Baviaan Baviaan requested a review from Gallaecio October 19, 2021 22:21
Gallaecio
Gallaecio approved these changes Oct 20, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Gallaecio Gallaecio merged commit e6d4bf1 into scrapinghub:master Oct 21, 2022
@Baviaan Baviaan mentioned this pull request Nov 6, 2022
Closed
@MxMarx MxMarx mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhii73 serhii73 serhii73 approved these changes

+1 more reviewer

@Gallaecio Gallaecio Gallaecio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Returned datetime skips a day with time+timezone input and PREFER_DATES_FROM = 'future'

3 participants

@Baviaan @Gallaecio @serhii73