Skip to content

Commit f0f9102

Browse files
authored
Add tests to cover Finnish dates with 'klo' (#1301)
* Add tests to cover Finnish dates with 'klo' * Add Finnish "klo" (o'clock) to skip tokens and add translation test - Add "klo" to skip tokens in Finnish language data files - Modified: dateparser/data/date_translation_data/fi.py - Modified: dateparser_data/supplementary_language_data/date_translation_data/fi.yaml - Add translation test case for Finnish dates with "klo" - Modified: tests/test_languages.py This fixes parsing of Finnish dates like "28 maalis klo 9:37" (March 28 at 9:37). The word "klo" (abbreviation for "kello", meaning "o'clock") is now properly skipped during tokenization, allowing correct date parsing.
1 parent 920d725 commit f0f9102

4 files changed

Lines changed: 8 additions & 1 deletion

File tree

dateparser/data/date_translation_data/fi.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,7 @@
316316
"locale_specific": {},
317317
"skip": [
318318
":n",
319+
"klo",
319320
" ",
320321
"'",
321322
",",

dateparser_data/supplementary_language_data/date_translation_data/fi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
skip: [":n"]
1+
skip: [":n", "klo"]
22

33
sentence_splitter_group : 1
44

tests/test_date_parser.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,11 @@ def setUp(self):
214214
# Finnish dates
215215
param("5.7.2018 5.45 ip.", datetime(2018, 7, 5, 17, 45)),
216216
param("5 .7 .2018 5.45 ip.", datetime(2018, 7, 5, 17, 45)),
217+
param("28 maalis klo 9:37", datetime(2012, 3, 28, 9, 37)),
218+
param("28 maalis 9:37", datetime(2012, 3, 28, 9, 37)),
219+
param("15 tammi klo 14:30", datetime(2012, 1, 15, 14, 30)),
220+
param("5 kesä klo 18:00", datetime(2012, 6, 5, 18, 0)),
221+
param("12.5.2020 klo 16:45", datetime(2020, 5, 12, 16, 45)),
217222
# Croatian dates
218223
param("06. travnja 2021.", datetime(2021, 4, 6, 0, 0)),
219224
param("13. svibanj 2022.", datetime(2022, 5, 13, 0, 0)),

tests/test_languages.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ def setUp(self):
214214
param("fi", "su joulu 16, 2015", "sunday december 16 2015"),
215215
param("fi", "1. tammikuuta, 2016", "1. january 2016"),
216216
param("fi", "tiistaina, 27. lokakuuta 2015", "tuesday 27. october 2015"),
217+
param("fi", "28 maalis klo 9:37", "28 march 9:37"),
217218
# Japanese
218219
param("ja", "午後3時", "pm 3:00"),
219220
param("ja", "2時", "2:00"),

0 commit comments

Comments
 (0)