Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: scoverage/sbt-scoverage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.5
Choose a base ref
...
head repository: scoverage/sbt-scoverage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.6
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Oct 20, 2022

  1. Allow sbt-scoverage to work on Windows 

    The -Xplugin option expects a classpath string with multiple paths
separated by a semicolon or colon depending on the operating system.
However, this currently always uses a colon, which doesn't work on
Windows. This means scalac cannot find the scoverage plugin jars and
leads to errors about "bad options".

This modifies the -Xplugin logic to use File.pathSeparator when building
the Xplugin classpath, allowing it to work regardless of operating
system.

Also modifies excludedPackages when on Windows to replace Unix path
separators with Windows path separators (which are escaped because it is
treated as a regular expression). Modifies tests to remove unnecessary
escaping of Unix separators that results in an invalid regex due to this
replacement on Windows.

Note that two tests currently prevent CI from working on Windows:
coverage-off and preserve-set. The reason for these failures on Windows
is not clear, but these changes at least allow the common uses to work
on Windows.
    @stevedlawrence @ckipp01
    stevedlawrence authored and ckipp01 committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    8ba258c View commit details
    Browse the repository at this point in the history
Loading