Add default postgres-instance provisioner#284
Add default postgres-instance provisioner#284chris-stephenson merged 5 commits intoscore-spec:mainfrom
postgres-instance provisioner#284Conversation
Signed-off-by: rabelmervin <rabelmervin@gmail.com>
|
Bonjour Monsieur, @mathieu-benoit, sorry for the previous pr. Now its look cleaner and updated... |
chris-stephenson
left a comment
There was a problem hiding this comment.
Thanks for taking the time to submit the PR @rabelmervin ! We really appreciate the support.
I left a few comments - but this might be more related to me not fully understanding your usecase.
In your description you worte:
Unlike the postgres provisioner, postgres-instance does not provide database/name as an output.
It operates without shared resources (local )
The first one makes sense, but I don't understand you mean regarding the second point.
I assume that you want to allow a workload to have admin on the Postgres instance itself (a good example of this might be wanting to run backstage with score for example)
In this case there are a few things to consider:
- Should the postgres instance be the same as the one used by the
postgrestype? - How much of the original
postgresprovisioner would actually be required.
Feel free to follow up with questions or reach out on the CNCF slack if you have further questions.
Signed-off-by: rabelmervin <rabelmervin@gmail.com>
|
Hi @chris-stephenson Apologies for pushing the previous commit without properly addressing the issue. Thanks for your review |
Signed-off-by: rabelmervin <rabelmervin@gmail.com>
chris-stephenson
left a comment
There was a problem hiding this comment.
Almost there! Thanks for putting the time in. :)
Signed-off-by: rabelmervin <rabelmervin@gmail.com>
postgres-instance provisioner
|
Thanks @rabelmervin for this implementation, and thanks @chris-stephenson for the review, this is helping making this entire use case with Backstage working now! 🎉 |
Description
A new provisioner,
postgres-instance, has been added. It is similar to thepostgresprovisioner but differs in key aspects:Unlike the
postgresprovisioner,postgres-instancedoes not providedatabase/nameas an output.It operates without shared resources (local )