Skip to content

DEP: optimize: Add deprecation warnings to L-BFGS-B disp, iprint#23197

Merged
tylerjereddy merged 1 commit intoscipy:mainfrom
ilayn:warn_disp
Jun 20, 2025
Merged

DEP: optimize: Add deprecation warnings to L-BFGS-B disp, iprint#23197
tylerjereddy merged 1 commit intoscipy:mainfrom
ilayn:warn_disp

Conversation

@ilayn
Copy link
Copy Markdown
Member

@ilayn ilayn commented Jun 20, 2025

Reference issue

#23186

What does this implement/fix?

Added deprecation warnings for disp and iprint arguments of l-bfgs-b solver of scipy.optimize. Previously they were deprecated in the documentation since 1.15 for removal in 1.17 however the warning emission was forgotten. Hence to give users the same amount of slack time, the deprecation period is extended until 1.18.

@ilayn ilayn added this to the 1.16.0 milestone Jun 20, 2025
@ilayn ilayn requested a review from andyfaff as a code owner June 20, 2025 13:15
@ilayn ilayn added scipy.optimize deprecated Items related to behavior that has been deprecated labels Jun 20, 2025
@ilayn ilayn mentioned this pull request May 31, 2025
28 tasks
@ilayn
Copy link
Copy Markdown
Member Author

ilayn commented Jun 20, 2025

@tylerjereddy All yours, failure is not related.

@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 20, 2025
Copy link
Copy Markdown
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems "ok," CI is happy apart from the bleeding edge NumPy issue.

I suppose testing with pytest.deprecated_call() might be nice, but let's try to move forward for the release.

I'll try to adjust the release notes accordingly for the "new" deprecations.

@tylerjereddy tylerjereddy merged commit ecdcf48 into scipy:main Jun 20, 2025
38 of 39 checks passed
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 22, 2025
@ilayn ilayn deleted the warn_disp branch June 22, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecated Items related to behavior that has been deprecated scipy.optimize

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants