Skip to content

MAINT/DEV: lint: disable UP032#20629

Merged
lucascolley merged 1 commit intoscipy:mainfrom
rgommers:lint-no-UP032
May 2, 2024
Merged

MAINT/DEV: lint: disable UP032#20629
lucascolley merged 1 commit intoscipy:mainfrom
rgommers:lint-no-UP032

Conversation

@rgommers
Copy link
Copy Markdown
Member

@rgommers rgommers commented May 2, 2024

Showed up as a linting error in an unrelated PR for me:

scipy/interpolate/_interpolate.py:918:30: UP032 [*] Use f-string instead of `format` call
scipy/interpolate/_interpolate.py:1972:30: UP032 [*] Use f-string instead of `format` call

This should not happen; the old code is fine, so this check needs to be silenced or fixed separately. Similar to gh-20601.

[skip ci]

I believe I saw @mdhaber also complaining about having to chase f-string related issues unrelated to code he was touching this week (just can't find the PR back).

Showed up as a linting error in an unrelated PR for me:
```
scipy/interpolate/_interpolate.py:918:30: UP032 [*] Use f-string instead of `format` call
scipy/interpolate/_interpolate.py:1972:30: UP032 [*] Use f-string instead of `format` call
```
This should not happen; the old code is fine, so this check needs to be
silenced or fixed separately. Similar to scipygh-20601.

[skip ci]
@rgommers rgommers added the DX Everything related to making the experience of working on SciPy more pleasant label May 2, 2024
@rgommers rgommers requested a review from larsoner as a code owner May 2, 2024 16:54
@lucascolley
Copy link
Copy Markdown
Member

Thanks Ralf, let's tag fixing these onto the other issue

@lucascolley lucascolley changed the title DEV: lint: disable UP031 DEV: lint: disable UP032 May 2, 2024
@lucascolley lucascolley added the maintenance Items related to regular maintenance tasks label May 2, 2024
@lucascolley lucascolley changed the title DEV: lint: disable UP032 MAINT/DEV: lint: disable UP032 May 2, 2024
@lucascolley lucascolley added this to the 1.14.0 milestone May 2, 2024
@lucascolley lucascolley merged commit 10105c0 into scipy:main May 2, 2024
@rgommers rgommers deleted the lint-no-UP032 branch May 2, 2024 19:06
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 15, 2024
@tylerjereddy tylerjereddy modified the milestones: 1.14.0, 1.13.1 May 15, 2024
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Everything related to making the experience of working on SciPy more pleasant maintenance Items related to regular maintenance tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants