MAINT: bump OpenBLAS "the old way"#20215
Conversation
|
cc @mattip |
|
I think you can use the v0.3.26 tarballs from https://anaconda.org/scientific-python-nightly-wheels/openblas-libs, so you would need to modify tools/openblas_support.py: - OPENBLAS_V = '0.3.21.dev'
- OPENBLAS_LONG = 'v0.3.20-571-g3dec11c6'
+ OPENBLAS_V = '0.3.26'
+ OPENBLAS_LONG = 'v0.3.26' |
|
I tried that, but it turns into I'd probably have to start making shims to adjust this branch to match your new infrastructure, no? |
|
Sorry. I must have overwritten it at some point. It seems the previous one was - OPENBLAS_V = '0.3.21.dev'
- OPENBLAS_LONG = 'v0.3.20-571-g3dec11c6'
+ OPENBLAS_V = '0.3.24-dev'
+ OPENBLAS_LONG = 'v0.3.24-95-g9d425a5f' |
|
That fails too--I'm pretty sure I tried most of the binaries up there yesterday. I'll paste the error I got yesterday for that scenario below: |
|
Ok I will make sure there is a 0.3.26 you can use. It might take me a day or so. |
|
Which platforms do you need openblas tarballs for? Do you ship linux aarch64? That builds on travis which is flaky and not cooperating (this is a known problem with travis CI, would be nice to find a different aarch64 CI system but that is another problem). |
|
Cirrusci can handle Linux aarch64 relatively straightforwardly |
|
It seems #20228 is working, using the 0.3.26 tarballs I uploaded today to https://anaconda.org/multibuild-wheels-staging/openblas-libs/files |
* Related to scipygh-16930 * added a regression test, based on the reproducer in the issue, that I confirmed does indeed fail locally on x86_64 Linux via: `CIBW_BUILD=cp311-* cibuildwheel --platform linux --archs x86_64` * this assumes that scipygh-20074 needs a little more time because of all the moving parts related to that * I spent a few hours on this today, and unfortunately I don't see an obvious fix because the "newest of the old" OpenBLAS binaries we were using at https://anaconda.org/multibuild-wheels-staging/openblas-libs/files are too old to fix the test via `cibuildwheel` in my hands; conversely, the new OpenBLAS binaries (https://anaconda.org/scientific-python-nightly-wheels/openblas-libs/files) don't seem to offer a version that is simultaneously new enough while not introducing at least a subset of the challenges experienced by scipygh-20074 (yikes!) [skip cirrus] [skip circle]
* attempt a wheel build after pulling in fixes from Matti P. to bump to OpenBLAS `0.3.26` (and after Matti built special "old style" binaries for this upstream) [wheel build]
c1ef625 to
028ce68
Compare
|
@mattip Awesome, thanks a lot! I confirmed locally that with your commits pulled in from the cross-linked PR combined with your work to provide a new OpenBLAS build upstream, this branch passes the regression test to fix the issue in question. I'm going to proceed with a full wheel build with your two commits cherry-picked in here now, and if there are no related failures we can move forward I think. |
|
@andyfaff is there a way for me to manually override the Cirrus Linux ARM wheel build skips on a PR/feature branch like this? (without changing the source code--I'm pretty sure my manual re-run trigger just skipped again and uploaded some previous artifact) |
|
Do I understand you want the cirrus runs to be forced to go again? If so, I've just forced them to run again. |
|
So close! A single failure on the macOS x86-64 jobs: So perhaps not fully fixed upstream. Perhaps drop the added test from this PR, and @ev-br may want to investigate further? Getting OpenBLAS 0.3.26 shipped in the next release will be quite nice either way. |
|
Sure, feel free to skip it, I'll take a look. dnrm2 sounds familiar. |
* skip the new regression test because OpenBLAS `0.3.26` doesn't fully fix scipygh-16930 [skip circle] [skip cirrus]
|
Looks like the wheels failed the new test on a few different platforms even with OpenBLAS Once the regular CI is happy, perhaps we should squash-merge. |
|
I believe the remaining CI failures are gh-20230. |
|
I squash-merged--I'd like to see a few days of the new OpenBLAS getting flushed through before branching for |
Not ready for merge... this is actually quite messy to fix I think, because of our current infrastructure transition around OpenBLAS.
Related to BUG: scipy.linalg.blas.dnrm2 may return error result when incx < 0 #16930
added a regression test, based on the reproducer in the issue, that I confirmed does indeed fail locally on x86_64 Linux via:
CIBW_BUILD=cp311-* cibuildwheel --platform linux --archs x86_64this assumes that MAINT: Remove
openblas_support.py#20074 needs a little more time because of all the moving parts related to thatI spent a few hours on this today, and unfortunately I don't see an obvious fix because the "newest of the old" OpenBLAS binaries we were using at https://anaconda.org/multibuild-wheels-staging/openblas-libs/files are too old to fix the test via
cibuildwheelin my hands; conversely, the new OpenBLAS binaries (https://anaconda.org/scientific-python-nightly-wheels/openblas-libs/files) don't seem to offer a version that is simultaneously new enough while not introducing at least a subset of the challenges experienced by MAINT: Removeopenblas_support.py#20074, like the symbol/linking issues (yikes!)[skip cirrus] [skip circle]