BLD: simplifications in meson.build files#20121
Merged
tylerjereddy merged 4 commits intoscipy:mainfrom Feb 21, 2024
Merged
Conversation
Using a generator is analogous to how it's done for Cython, and easier to understand.
Use a generator where possible, and also avoid invoking the Python interpreter with `py3, tempita` but rather relying on Meson's `find_program` via a shebang.
b64e3e1 to
0d19f3c
Compare
Member
Author
|
This is happy now, should be good to go. |
tylerjereddy
approved these changes
Feb 21, 2024
Contributor
tylerjereddy
left a comment
There was a problem hiding this comment.
I read the full diff and tested against NumPy main locally, seems like useful cleanup thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
custom_target'spy3but rather rely on shebang files