Skip to content

MAINT:linalg:Adjust lwork/liwork changes OpenBLAS 0.3.26#19909

Merged
ilayn merged 1 commit intoscipy:mainfrom
ilayn:evr_liwork
Jan 18, 2024
Merged

MAINT:linalg:Adjust lwork/liwork changes OpenBLAS 0.3.26#19909
ilayn merged 1 commit intoscipy:mainfrom
ilayn:evr_liwork

Conversation

@ilayn
Copy link
Copy Markdown
Member

@ilayn ilayn commented Jan 18, 2024

Closes #19831

See Reference-LAPACK/lapack#942. The default values of {l, li, lr}work has changed for small n. This fixes our LAPACK wrappers. It looked like evr family is the one that got hit in our wrappers but if more we can use this template for them too.

@ilayn ilayn requested a review from larsoner as a code owner January 18, 2024 13:50
@ilayn ilayn added this to the 1.13.0 milestone Jan 18, 2024
@github-actions github-actions bot added scipy.linalg maintenance Items related to regular maintenance tasks labels Jan 18, 2024
@ilayn
Copy link
Copy Markdown
Member Author

ilayn commented Jan 18, 2024

This one has no impact on the current setup hence merging.

@ilayn ilayn merged commit 0a7631f into scipy:main Jan 18, 2024
@ilayn ilayn deleted the evr_liwork branch January 18, 2024 15:39
@rgommers
Copy link
Copy Markdown
Member

Thanks @ilayn!

@h-vetinari
Copy link
Copy Markdown
Member

I'm adding a backport label here, it looks like we're hitting this with 1.12 now that conda-forge has openblas 0.3.26

@h-vetinari h-vetinari added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jan 23, 2024
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Items related to regular maintenance tasks scipy.linalg

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures with OpenBLAS 0.3.26

4 participants