BLD: resolve missing prototype warnings in lsoda/vode#19821
Merged
rgommers merged 1 commit intoscipy:mainfrom Jan 7, 2024
Merged
BLD: resolve missing prototype warnings in lsoda/vode#19821rgommers merged 1 commit intoscipy:mainfrom
rgommers merged 1 commit intoscipy:mainfrom
Conversation
rgommers
approved these changes
Jan 7, 2024
Member
rgommers
left a comment
There was a problem hiding this comment.
LGTM, thanks @thalassemia!
With Clang on macOS these warnings were visible too, and are indeed resolved now:
[9/12] Compiling C object scipy/integrate/_lsoda.cpython-310-darwin.so.p/meson-generated_..__lsodamodule.c.o
scipy/integrate/_lsodamodule.c:1045:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
(*f2py_func)(cb_f_in_lsoda__user__routines,&neq,y,&t,&tout,&itol,rtol,atol,&itask,&istate,&iopt,rwork,&lrw,iwork,&liw,cb_jac_in_lsoda__user__routines,&jt) ;
^
1 warning generated.
[11/12] Compiling C object scipy/integrate/_vode.cpython-310-darwin.so.p/meson-generated_..__vodemodule.c.o
scipy/integrate/_vodemodule.c:1452:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
(*f2py_func)(cb_f_in_dvode__user__routines,&neq,y,&t,&tout,&itol,rtol,atol,&itask,&istate,&iopt,rwork,&lrw,iwork,&liw,cb_jac_in_dvode__user__routines,&mf,&rpar,&ipar) ;
^
scipy/integrate/_vodemodule.c:1810:29: warning: passing arguments to a function without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
(*f2py_func)(cb_f_in_zvode__user__routines,&neq,y,&t,&tout,&itol,rtol,atol,&itask,&istate,&iopt,zwork,&lzw,rwork,&lrw,iwork,&liw,cb_jac_in_zvode__user__routines,&mf,&rpar,&ipar) ;
^
2 warnings generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves a compiler-specific warning that I encountered at some point during my testing with either MSVC or the Intel compilers (don't remember which).