TST: linalg: Test Cython LAPACK complex ladiv#19820
Merged
rgommers merged 1 commit intoscipy:mainfrom Jan 7, 2024
Merged
Conversation
Member
|
Strange this should automatically come from LAPACK auto generated wrappers. Ah nevermind you added the tests not the funcs. |
lucascolley
reviewed
Jan 7, 2024
d7a7121 to
ccc5a12
Compare
ccc5a12 to
8b4eef3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my experience, modifying the BLAS/LAPACK interface often causes functions with complex return values to have inconsistent behavior across platforms. With ILP64 support and other changes slated for the near future, this PR completes test coverage of these functions by adding tests for
[c/d]ladivon top of the existing tests for[c/z]dot[c/u].