MAINT: Add inline type hintings for stats.qmc#13833
Merged
tupui merged 1 commit intoscipy:masterfrom May 19, 2021
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following @tupui and @rgommers comment on #13576, I am submitting this PR to remove
_qmc.pyito add inline type hinting inside_qmc.pyReference issue
None
What does this implement/fix?
This implementation remove a type files (
qmc.pyi) and replace it by inline typing directly inside_qmc.py