Convert dict-like args from compatible types #3798
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to #3797 this allows more flexible dict-like arguments in some functions. I specifically ran into this when using
da.assign_coords(other.coords)which should intuitively be allowed. But mypy complained becauseassign_coordsrequired a dict. (There was no problem at runtime.)Note that there are two changes in behaviour:
dict().kwargsnow raisesTypeErrorinstead ofValueError. This matches the existing behaviour of bin, hist, etc. and more closely matches the typical error you get from bad function calls.