docs: extend masking docs with examples #3738
Conversation
docs/user-guide/masking.ipynb
Outdated
| "metadata": {}, | ||
| "source": [ | ||
| "In the example above the mask was specified as the data array was created.\n", | ||
| "But like for `coords` masks can also be assigned after the data array was created:" |
There was a problem hiding this comment.
[Minor]
| "But like for `coords` masks can also be assigned after the data array was created:" | |
| "However, similar to `coords`, `masks` can also be assigned on an existing `DataArray` instance:" |
Sth like this maybe...?
There was a problem hiding this comment.
Yeah that's better, I'll update and reword it similar to that
There was a problem hiding this comment.
I am not sure we can assign to masks? I suppose you mean setting items?
There was a problem hiding this comment.
But the interface is called assign_masks though...?
You mean it's not possble on the same instance?
There was a problem hiding this comment.
assign_masks return a new object, yes. Also, the example right after this text sets a mask. It is not assigning the masks property.
Co-authored-by: Sunyoung Yoo <17974113+YooSunYoung@users.noreply.github.com>
9cc549c to
7e1ba6c
Compare
|
@scipp/scipp-maintainers |
Fixes #3699