Allow to not use deps from conan #3704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2025
Member
|
Urggh looks like our CI is acting up if the PR comes from a fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'd like to distribute this (so it seems) excellent software to Nixpkgs - the package collection of Nix - the purely functional package manager.
A pure functional package manager is a package manager that doesn't allow a build process access the internet during the build. As such, we cannot use
conanin our build processes like others. That's why we have no choice but to patchscippto accommodate to using our externally built dependencies. I managed to do that with this patch.This PR is also a good opportunity to report that I managed to build the project with llnl-units 0.13.1 (related to #3697) :). If you'd accept this change, the new
USE_CONANCMake option should be mentioned somewhere in https://scipp.github.io/development/getting-started.html - not sure where yet.