Fix more type issues #3684
Merged
Fix more type issues #3684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use a union in the tuple to allow passing unions as argument. The overloads only allow for inputs of a single type (int, slice, etc.) but not int|slice.
Member
|
I admire the work put into this. As for the changes here, I did not look in detail, but Copilot seems happy enough ;-) |
Member
Author
|
I ran some simple benchmarks of |
nvaytet
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixes the last remaining issues in the package source. At least as far as they can be found by checking the source alone. We may find more by checking all tests and downstream packages.
I also started fixing issues in tests. But this is not done yet.