Enable more reduction operations along multiple dimensions #3673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to enable reduction operations along multiple dimensions.
- Added a new test (test_reduce_two_dims) to verify that reduction functions work correctly when applied over multiple dimensions.
- Refactored reduction functions in src/scipp/core/reduction.py to support multiple dimensions via the new _apply_op helper.
- Updated docstrings and type hints across reduction functions to consistently indicate support for multiple dimensions.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/core/reduction_test.py | Introduced tests for multi-dimension reductions with various dimension orderings. |
| src/scipp/core/reduction.py | Refactored reduction functions to leverage _apply_op for handling multiple dimensions. |
Comments suppressed due to low confidence (1)
tests/core/reduction_test.py:981
- [nitpick] Consider renaming 'possibles' to a more descriptive name like 'dim_permutations' to enhance code clarity.
possibles = (['xx', 'yy', 'zz'], ['yy', 'zz', 'xx'], ['zz', 'xx', 'yy'])
jl-wynen
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3569