Fix typing in HDF5 IO #3666
Merged
Fix typing in HDF5 IO #3666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokasimr
approved these changes
Mar 11, 2025
Comment on lines
+449
to
+458
| coords = cast(dict[str, Variable], _read_mapping(group['coords'])) | ||
| override = {'coords': coords} | ||
| data: MutableMapping[str, Variable | DataArray] = {} | ||
| for g in group['entries'].values(): | ||
| name = g.attrs['name'] | ||
| if g.attrs['scipp-type'] == 'DataArray': | ||
| data[name] = _DataArrayIO.read(g, override=override) | ||
| else: | ||
| data[name] = _VariableIO.read(g) | ||
| return Dataset(coords=coords, data=data) |
Contributor
There was a problem hiding this comment.
Why can't we use _read_mapping here to create the data argument anymore?
Contributor
There was a problem hiding this comment.
Aha is it related to this?
This revealed an error in the dataset reader. The coord overrides where passed when reading the component data arrays but were not forwarded to the data array coord loader. So we were loading coords twice.
Member
Author
There was a problem hiding this comment.
Exactly. This is the error that I fixed. (It was correct before but wasted time re-reading the same variables.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change here is specifying and adhering to common interfaces for all
*IOclasses.This revealed an error in the dataset reader. The coord overrides where passed when reading the component data arrays but were not forwarded to the data array coord loader. So we were loading coords twice. The new implementation fixes that.