Further reduce overhead in bin and group #3643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the mappers computed (and allocated variables) containing the output bin sizes. These were then used to compute (and allocate variables for) output bin indices. As the sizes themselves are not needed, we can skip this and directly setup the indices. This saves around 20% when grouping few rows into O(1M) bins.
This was referenced Jan 28, 2025
Merged
jl-wynen
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the mappers computed (and allocated variables containing) the output bin sizes. These were then used to compute (and allocate variables for) output bin indices. As the sizes themselves are not needed, we can skip this and directly setup the indices. This saves around 20% when grouping few rows into O(1M) bins.
We are now entering the territory of noise for my benchmark setup, but I think this improvement is still significant:
Fixes #3637 (in a sense, probably there are more gains to be made).