Avoid bin index validation in bin and group operations #3638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since bin indices were computed form bin sizes, validation of the indices is not necessary. On my computer this saves around 25 ms for 1M bins and 350 ms for 10M bins.
dc53585 to
5d3446c
Compare
nvaytet
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since bin indices were computed from bin sizes, validation of the indices is not necessary. On my computer this saves around 25 ms for 1M bins and 350 ms for 10M bins in calls to
group(probably similar forbin).The improvement from the second commit is less clear. Maybe around 10 ms for 10M bins. Might be more relevant in an environment with fewer threads.
Part of #3637.