Appease mypy #3636
Merged
Appease mypy #3636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbca7bd to
6069294
Compare
SimonHeybrock
approved these changes
Jan 27, 2025
Comment on lines
190
to
-203
| exclude = [ | ||
| 'scipp/__init__\.py', | ||
| 'scipp/coords/', | ||
| 'scipp/curve_fit\.py', | ||
| 'scipp/format/formatter\.py', | ||
| 'scipp/io/hdf5\.py', | ||
| 'scipp/logging\.py', | ||
| 'scipp/object_list\.py', | ||
| 'scipp/operations\.py', | ||
| 'scipp/reduction\.py', | ||
| 'scipp/scipy/integrate/__init__\.py', | ||
| 'scipp/scipy/optimize/__init__\.py', | ||
| 'scipp/testing/strategies\.py', | ||
| 'scipp/utils/profile\.py', |
Member
There was a problem hiding this comment.
Nice, list is getting very short!
Comment on lines
-22
to
-31
| from typing import Protocol as _Protocol | ||
|
|
||
| # Importing CoordTable from coord_table.py would result in an import | ||
| # cycle because that module imports rule.py | ||
| # CoordTable is only needed for type annotations here, | ||
| # so a protocol is enough. | ||
| class _CoordProvider(_Protocol): | ||
| def consume(self, name: str) -> Coord: | ||
| pass | ||
|
|
Member
There was a problem hiding this comment.
Was the comment wrong, or what has changed?
Member
Author
There was a problem hiding this comment.
It wasn't wrong. But the new solution matches what we do in other places (
scipp/src/scipp/coords/rule.py
Lines 21 to 24 in 6069294
6069294 to
4d82f7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same procedure as every time