Force set alignment of attrs to False when reading legacy files #3632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Jan 15, 2025
Member
jl-wynen
left a comment
There was a problem hiding this comment.
Good catch! The old attrs should indeed be unaligned. I missed this in the original PR.
src/scipp/io/hdf5.py
Outdated
| g.attrs['name']: override[g.attrs['name']] | ||
| if g.attrs['name'] in override | ||
| else _HDF5IO.read(g) | ||
| else _HDF5IO.read(g, aligned=aligned) |
Member
There was a problem hiding this comment.
This does not match the common interface of readers. And it doesn't make sense in general because only coords can be aligned, not, e.g., data groups.
I think it would be easiest to modify _read_legacy_attrs_into to add coords to a DataArray directly instead of the contents dict. Then you can use Coords.set_aligned.
jl-wynen
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this!
If we are reading a legacy HDF5 file which was written with attrs in it, it will have the
alignedset toTrue(tried this with scipp=24.11.2) for that attribute. But if I read the file in which has the old attrs in it, we should always set the new coord as unaligned for that attr right?Maybe this is better solution than scipp/esssans#192 ?