-
Notifications
You must be signed in to change notification settings - Fork 21
Use conda for c++ deps, take 2 #3628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Alrighty, this is ready for review. The main change here is that while building the conda package now we will use the packages from conda and while building the wheel we stick to conan to fetch the deps. I also made some changes to the cpp code to make compilers on mac and windows happy. The windows one was complaining about using reserverd keywords like Another thing that could be controversial is that I am using different tbb versions for conda and pypi. conda has the latest The last commit has the action build logs for wheels and conda https://github.com/scipp/scipp/actions/runs/12706404682/job/35419301931 |
We should check if this works with Mantid. In the past we had to stick with some older version because Mantid uses it as well. |
SimonHeybrock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Minor questions/comments.
Hmm, need to find a machine to run the test. I guess running this https://scipp.github.io/scippneutron/user-guide/from-mantid-to-scipp.html should be enough right? |
Yes. Why can't you use your own machine? The TBB version bump happened across platforms, didn't it? |
mantid on conda doesn't work with Mac ARM? |
|
I was able to go through https://scipp.github.io/scippneutron/user-guide/from-mantid-to-scipp.html on a linux machine just fine. I just checked to see if there were any errors pop up in cells. Didn't see anything pop up. |
No description provided.