Remove attrs #3626
Merged
Remove attrs #3626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
reviewed
Jan 2, 2025
| contents['name'] = group.attrs['name'] | ||
| contents['data'] = _VariableIO.read(group['data']) | ||
| for category in ['coords', 'masks', 'attrs']: | ||
| for category in ['coords', 'masks']: |
Member
There was a problem hiding this comment.
Should we consider supporting legacy files and read from the attrs group as unaligned coords? Updating all the files in our tests data would be a fair amount of work.
Member
Author
There was a problem hiding this comment.
We could. But that can also break tests because the data arrays are suddenly different.
Member
There was a problem hiding this comment.
That is easier to fix than recreating a lot of files? Furthermore, some IDS or IS may have Scipp HDF5 files as well.
Member
Author
There was a problem hiding this comment.
I implemented this. Do you have any more comments?
SimonHeybrock
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3412
I did not test downstream packages. Our nightly at main tests should tell us whether something breaks.