Appease mypy some more #3624
Merged
Appease mypy some more #3624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
commented
Dec 19, 2024
| DataArray.drop_attrs = _deprecated_drop_attrs | ||
| DataArray.attrs = property(_deprecated_attrs) # type: ignore[assignment, method-assign] | ||
| DataArray.meta = property(_deprecated_meta) # type: ignore[assignment, method-assign] | ||
| DataArray.drop_attrs = _deprecated_drop_attrs # type: ignore[assignment, method-assign] |
Member
Author
There was a problem hiding this comment.
Mypy doesn't like this because cpp_classes.pyi lists all methods of Dataarray, etc. and we are not allowed to assign to methods. However, at runtime, these methods don't exist before the assignments here. So we just need to silence mypy and make it use the stubs instead.
jl-wynen
commented
Dec 19, 2024
| structured, # type: ignore[name-defined] | ||
| trigonometry, # type: ignore[name-defined] | ||
| unary, # type: ignore[name-defined] | ||
| variable, # type: ignore[name-defined] |
Member
Author
There was a problem hiding this comment.
Mypy doesn't like that we delete modules here. But it's fine at runtime.
SimonHeybrock
approved these changes
Dec 20, 2024
Comment on lines
+198
to
+199
| meta: dict[str, dict[str, Variable]] = {"coords": {}, "masks": {}, "attrs": {}} | ||
| for key in meta.keys(): |
Member
There was a problem hiding this comment.
Interesting we are still using the deprecated attribute meta here?
Member
Author
There was a problem hiding this comment.
We aren't? meta is a local variable. But we do still use attrs which we should now remove.
a73406c to
aff8c8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.