Fix typing issues #3495
Merged
Fix typing issues #3495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonHeybrock
approved these changes
Jul 10, 2024
Merged
This makes the methods consistent with Mapping
Member
Author
|
This PR now targets #3497 I fixed the remaining issues in the stub. |
jl-wynen
commented
Jul 11, 2024
| bind_binary<Dataset>(dataset); | ||
| bind_binary<DataArray>(dataset); | ||
| bind_binary<Variable>(dataset); | ||
| bind_binary_scalars(dataset); |
Member
Author
There was a problem hiding this comment.
This showed up because Dataset.__add__ and Dataset.__iadd__ were inconsistent. Only the latter supported floats on the RHS.
There are still inconsistencies in Variable and DataArray because they allow binary ops with Dataset but not in-place ops. This makes sense. But I think the clean solution would be, e.g., to not implement Variable.__add__(Dataset) but instead Dataset.__radd__(Variable). I can do that but I don't know how much of a refactor that would be. So I didn't.
SimonHeybrock
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some miscellaneous errors but focusses on low level modules.