Request for comments: ADR on not supporting attributes #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
approved these changes
May 16, 2023
jl-wynen
reviewed
May 16, 2023
Member
jl-wynen
left a comment
There was a problem hiding this comment.
Just some typos. Looks good otherwise.
Co-authored-by: Jan-Lukas Wynen <jan-lukas.wynen@ess.eu>
jl-wynen
approved these changes
May 17, 2023
nvaytet
reviewed
May 17, 2023
jl-wynen
reviewed
May 17, 2023
|
|
||
| If we consider binary operations (such as addition or division) then it is not clear how attributes should be handled if they mismatch between operands or are missing in one operand. | ||
| This is an example where Scipp made a different choice than Xarray. | ||
| In Xarray, ``((a + b) + c).attrs != (a + (b + c)).attrs`` whereas in Scipp ``((a + b) + c).attrs == (a + (b + c)).attrs``. |
Member
There was a problem hiding this comment.
Can you give an example when this happens?
| In practice attributes are very frequently dropped in binary operations. | ||
| This raises some questions about the usability of the mechanism. | ||
| Xarray's approach is more "useful", at the cost of consistency. | ||
| Xarray's mechanism furthermore necessiated complications, such as global settings that influence the behavior as well as certain interfaces with keyword arguments to define attribute handling. |
Member
There was a problem hiding this comment.
Suggested change
| Xarray's mechanism furthermore necessiated complications, such as global settings that influence the behavior as well as certain interfaces with keyword arguments to define attribute handling. | |
| Xarray's mechanism furthermore necessitates complications, such as global settings that influence the behavior as well as certain interfaces with keyword arguments to define attribute handling. |
Closed
SimonHeybrock
commented
May 30, 2023
SimonHeybrock
commented
May 30, 2023
nvaytet
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to describe our current reasoning. Did I forget anything?
Note that the ADR is marked as "draft", i.e., not something we have made a decision on.