Add under and over to colormaps #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/plopp/graphics/colormapper.py
Outdated
| def _get_cmap(colormap: str | Colormap, nan_color: str | None = None) -> Colormap: | ||
| """ | ||
| Get a colormap object from a colormap name. | ||
| We also set |
Comment on lines
+63
to
+67
| [_shift_color(c, delta * (-1 + 2 * (np.mean(over) > 0.5))) for c in over[:3]] | ||
| ) | ||
| cmap.set_under( | ||
| [_shift_color(c, delta * (-1 + 2 * (np.mean(under) > 0.5))) for c in under[:3]] | ||
| ) |
Member
There was a problem hiding this comment.
What is the meaning of applying this to the first 3?
Member
Author
There was a problem hiding this comment.
We don't want to change the alpha/transparency. I'll add a comment.
SimonHeybrock
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add under and over colors to colormaps to make more obvious colors that are out of range.
The colors are created by slightly shifting the first and last color of the colormap in the RGB space.