Skip to content

Conversation

@nvaytet
Copy link
Member

@nvaytet nvaytet commented Jul 26, 2025

Fixes #466

Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small suggestion.

"we update the index node and notify the children nodes of the change.\n",
"This updates the figure at every step.\n",
"\n",
"Finally, we save the animation to a `.gif` file.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also show how to display the animation in a notebook directly? Or is this not possible with mpl?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make a markdown cell and insert an image there, no?
In any cases, it'd be nice to have an example here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the markdown would get rendered before the code was run, and therefore not work, but apparently it works with just a markdown cell.

Another way is to just display the figure f in the notebook, but that only works with %matplotlib widget.

@nvaytet nvaytet merged commit 69b3cc3 into main Aug 5, 2025
4 checks passed
@nvaytet nvaytet deleted the animations-example branch August 5, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add animation example in the docs

4 participants