-
Notifications
You must be signed in to change notification settings - Fork 5
Add animations example to docs #473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jl-wynen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small suggestion.
| "we update the index node and notify the children nodes of the change.\n", | ||
| "This updates the figure at every step.\n", | ||
| "\n", | ||
| "Finally, we save the animation to a `.gif` file.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also show how to display the animation in a notebook directly? Or is this not possible with mpl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can make a markdown cell and insert an image there, no?
In any cases, it'd be nice to have an example here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the markdown would get rendered before the code was run, and therefore not work, but apparently it works with just a markdown cell.
Another way is to just display the figure f in the notebook, but that only works with %matplotlib widget.
Fixes #466