Skip to content

Add player to slicing slider widgets #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nvaytet merged 9 commits into from
Jul 15, 2025
Merged

Add player to slicing slider widgets #467

nvaytet merged 9 commits into from
Jul 15, 2025

Conversation

@nvaytet
Copy link
Member

@nvaytet nvaytet commented Jul 7, 2025 •
edited
Loading

Example:

import plopp as pp

da = pp.data.data3d()
pp.slicer(da, keep=['x', 'y'], enable_player=True)

Screenshot_20250707_161139

Fixes #462

Note that I decided to disable it for RangeSlider because it would really complicate things, especially when the looping is enabled, then the max would temporarily become the min, etc...

@nvaytet nvaytet requested a review from YooSunYoung July 7, 2025 21:15
@nvaytet nvaytet marked this pull request as ready for review July 7, 2025 21:15
jl-wynen
jl-wynen reviewed Jul 8, 2025
View reviewed changes
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but two requests about the docs:

  • Can you show the new argument in the slicer docs page?
  • And can you link from the scatter 3d gallery to the slicer docs? I first went to the gallery to test the feature but couldn't find any examples.

@nvaytet
Copy link
Member Author

nvaytet commented Jul 14, 2025

  • Can you show the new argument in the slicer docs page?

Done.

  • And can you link from the scatter 3d gallery to the slicer docs? I first went to the gallery to test the feature but couldn't find any examples.

Can you clarify what you wanted? Did you want a link from the Scatter3d plot with slider to the docs page for the slicer plot?
In which case I'm not sure it's super related as the slicer plot is only for 1d/2d data.
The example in the gallery is basically the answer to the question "can I also make this plot with a 3d scatter?"

Ah, maybe you meant "can you link from the slicer plot docs to the gallery example" to answer this exact question?

Or maybe you meant "can i link to the API reference of the SlicerWidget from the scatter3d with slicer gallery example?

@jl-wynen
Copy link
Member

jl-wynen commented Jul 15, 2025

  • And can you link from the scatter 3d gallery to the slicer docs? I first went to the gallery to test the feature but couldn't find any examples.

Can you clarify what you wanted? Did you want a link from the Scatter3d plot with slider to the docs page for the slicer plot? In which case I'm not sure it's super related as the slicer plot is only for 1d/2d data. The example in the gallery is basically the answer to the question "can I also make this plot with a 3d scatter?"

Ah, maybe you meant "can you link from the slicer plot docs to the gallery example" to answer this exact question?

Or maybe you meant "can i link to the API reference of the SlicerWidget from the scatter3d with slicer gallery example?

I'm not sure myself anymore. I think I wanted to link from Scatter3d plot with slider. But looking at it now, I agree that it doesn't make sense.

I think it is fine the way it is.

@nvaytet
Copy link
Member Author

nvaytet commented Jul 15, 2025

I added a link to answer the question "can I also make this plot with a 3d scatter?"

@nvaytet
Copy link
Member Author

nvaytet commented Jul 15, 2025 •
edited
Loading

@jl-wynen do you know why relative links like ../generated/plopp.slicer.html do not work ?

Never mind, I fixed it with .rst and .ipynb extensions.

@nvaytet nvaytet merged commit 1e05235 into main Jul 15, 2025
4 checks passed
@nvaytet nvaytet deleted the play-slider branch July 15, 2025 09:10
This was referenced Aug 5, 2025
Closed
Merged
@nvaytet nvaytet mentioned this pull request Jan 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jl-wynen jl-wynen jl-wynen approved these changes

@YooSunYoung YooSunYoung Awaiting requested review from YooSunYoung

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Play button for slicer

3 participants

@nvaytet @jl-wynen