Remove conda uploads to scipp channel #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
approved these changes
Jun 30, 2025
Member
MridulS
left a comment
There was a problem hiding this comment.
Yeah, we don't necessarily need to worry about plopp as there isn't any conda specific compilation steps here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #414
What if we publish a release and the conda build fails?
At first, I thought we should keep the conda build in the release workflow, to make sure that the conda build still works before we release.
However, the recipe in our repo is actually different from the one in the feedstock (they are not necessarily in sync).
For as long as I can remember, conda build failures have lately almost only been some dependencies that were missing from the recipe.
If this happens again on the conda forge build, we just fix the recipe on the
plopp-feedstock, and we don't need to re-release here.So I think it is safe to remove the conda build entirely?