-
Notifications
You must be signed in to change notification settings - Fork 5
Change colors of theme and logo in docs #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jl-wynen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hard blockers here. But should we ask around if everyone is happy with the new colours? Or if someone wants a different colour for their favourite package?
docs/_static/custom.css
Outdated
| @@ -0,0 +1,9 @@ | |||
| html[data-theme="light"] { | |||
| --pst-color-primary: #800080; | |||
| --pst-color-secondary: #ed4c5c; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for adjusting the theme colour.
But why did you pick a secondary colour that is so similar to Scitacean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why did you pick a secondary colour that is so similar to Scitacean?
No idea, I looked at some palettes online and tried to find a colour that would go well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could pick some blue/green/turquoise color maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit sad that the dark mode logo is white. How hard would it be to make a version with an adjusted colour? Is it enough to automatically increase lightness and decrease saturation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it enough to automatically increase lightness and decrease saturation?
Would be very useful if we could do that for logo and also the dark version of the primary/secondary colors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automatically increase lightness and decrease saturation
Can you do that dynamically? (i.e. without making a deparate 'dark' file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sort of. You can apply CSS rules to SVGs. But then you should probably modify the SVG's code to add some classes or ids so that you can identify the elements you want to style.
I have not received much in terms of wishes for colors from the instrument teams. However, this PR is just setting the color for Plopp, it is not saying that we have finalized and locked the color scheme for all projects. |
|
@jl-wynen see update with green color as secondary, and coloured dark logo. |
No description provided.