Skip to content

Conversation

@nvaytet
Copy link
Member

@nvaytet nvaytet commented Apr 3, 2025

No description provided.

@nvaytet nvaytet marked this pull request as ready for review April 3, 2025 12:13
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hard blockers here. But should we ask around if everyone is happy with the new colours? Or if someone wants a different colour for their favourite package?

@@ -0,0 +1,9 @@
html[data-theme="light"] {
--pst-color-primary: #800080;
--pst-color-secondary: #ed4c5c;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for adjusting the theme colour.

But why did you pick a secondary colour that is so similar to Scitacean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why did you pick a secondary colour that is so similar to Scitacean?

No idea, I looked at some palettes online and tried to find a colour that would go well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could pick some blue/green/turquoise color maybe?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit sad that the dark mode logo is white. How hard would it be to make a version with an adjusted colour? Is it enough to automatically increase lightness and decrease saturation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it enough to automatically increase lightness and decrease saturation?

Would be very useful if we could do that for logo and also the dark version of the primary/secondary colors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatically increase lightness and decrease saturation

Can you do that dynamically? (i.e. without making a deparate 'dark' file)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sort of. You can apply CSS rules to SVGs. But then you should probably modify the SVG's code to add some classes or ids so that you can identify the elements you want to style.

@nvaytet
Copy link
Member Author

nvaytet commented Apr 7, 2025

But should we ask around if everyone is happy with the new colours? Or if someone wants a different colour for their favourite package?

I have not received much in terms of wishes for colors from the instrument teams. However, this PR is just setting the color for Plopp, it is not saying that we have finalized and locked the color scheme for all projects.

@nvaytet
Copy link
Member Author

nvaytet commented Apr 10, 2025

@jl-wynen see update with green color as secondary, and coloured dark logo.

@nvaytet nvaytet merged commit 5810660 into main Apr 10, 2025
4 checks passed
@nvaytet nvaytet deleted the new-docs-colors branch April 10, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants