Make more artist properties available #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends artist functionality by adding new properties for visibility, opacity, style, marker, and width across various backends. Key changes include:
- Adding tests for the new visible and opacity properties.
- Implementing visible and opacity properties in the pythreejs, plotly, and matplotlib backends.
- Extending the line artist properties by including style, marker, and width in both plotly and matplotlib backends.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/graphics/artists_test.py | Added tests for the new visible and opacity properties; note an issue with test naming. |
| src/plopp/backends/pythreejs/scatter3d.py | Added a visible property for scatter3d. |
| src/plopp/backends/pythreejs/mesh3d.py | Added visible property adjustments for mesh3d (including edges). |
| src/plopp/backends/plotly/line.py | Added style, width, marker, visible, and opacity properties. |
| src/plopp/backends/matplotlib/scatter.py | Added visible, color, and opacity properties for scatter. |
| src/plopp/backends/matplotlib/mesh_image.py | Added visible and opacity properties for mesh images. |
| src/plopp/backends/matplotlib/line.py | Added style, width, marker, visible, and opacity properties. |
| src/plopp/backends/matplotlib/fast_image.py | Added visible and opacity properties for fast image rendering. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jl-wynen
approved these changes
Apr 9, 2025
Member
Author
|
@jokasimr once this is released, it should make some things in the reflectometry GUI easier (showing/hiding lines when checkboxes are clicked) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
visibleandopacityproperties on all artists.Add also
style,markerandwidthto the line artists.Fixes #427