Remove attrs use #241
Merged
Remove attrs use #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Member
Author
|
Depends on scipp/scipp#3231 and a release thereof. |
nvaytet
approved these changes
Sep 5, 2023
Member
|
This will mean that old code that uses attrs would potentially not work anymore. |
Member
Author
If you refer to Scipp older than 23.07, then yes. If they have at least 23.07 it should work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for deprecation of
DataArray.attrs.The previous use of
attrsthatploppcared about has anyway been changed previously: Unaligned coordinates are already stored incoordswith unset alignment flag since Scipp 23.07. Therefore, I expect that this change has little impact.