Zw figure fix #132
Zw figure fix #132
Conversation
| sample, | ||
| reference, | ||
| reference.coords['wavelength'], | ||
| ) |
There was a problem hiding this comment.
Can you check that the result is reasonable, not just that the function doesn't raise? If you can't check the values directly, you can at least check the sizes and that the right coords are present.
There was a problem hiding this comment.
The intent of the test is to check that the function doesn't raise if we have non-count weights, because that was the bug that prompted this issue.
Adding a bunch of extra checks for no apparent reason doesn't make sense in my opinion.
There was a problem hiding this comment.
Well, the reason is that the function can still misbehave without raising. In any case, there should be at least one more test to make sure that it produces a meaningful result.
| Returns reflectivity as a function of ``blade``, ``wire`` and :math:`\\wavelength`. | ||
| """ | ||
| R = sample.bins.concat(('stripe',)).bin(wavelength=wbins) / reference.data | ||
| R.masks["too_few_events"] = reference.data < sc.scalar(1, unit="counts") |
There was a problem hiding this comment.
Is the mask not needed anymore?
There was a problem hiding this comment.
Yes that's right. It was needed when we normalized on the z-wavelength grid, but we don't do that anymore.
There was a problem hiding this comment.
What do you do instead? And why is there still a 'zw' in the function name?
There was a problem hiding this comment.
We normalize on the Q-grid. But that's not done in this function.
This function still normalizes on the zw grid, but that is not used for the reduction, only for visualization purposes, and for visualization masking is not necessary.
Fixes #130