Skip to content

Conversation

@jokasimr
Copy link
Contributor

@jokasimr jokasimr commented Mar 4, 2025

Test using the cloudflare cache to speed up tests.

@jokasimr
Copy link
Contributor Author

jokasimr commented Mar 4, 2025

CI job tox -e py time:

  • first run 6min 51s
  • second run 1min 11s

@jokasimr
Copy link
Contributor Author

jokasimr commented Mar 4, 2025

The job failed once with some urllib error, so that's a bit worrying.

@MridulS
Copy link
Member

MridulS commented Mar 4, 2025

The job failed once with some urllib error, so that's a bit worrying.

What exactly was it?

@jokasimr
Copy link
Contributor Author

jokasimr commented Mar 4, 2025

@MridulS
Copy link
Member

MridulS commented Mar 4, 2025

Hmm, that just looks like a network interuption. It should hopefully just be a one off.

@jokasimr
Copy link
Contributor Author

jokasimr commented Mar 4, 2025

It should hopefully just be a one off.

Just a coincidence ;)

If it happens again we can look at it more.

@MridulS
Copy link
Member

MridulS commented Mar 4, 2025

What are we optimising here for btw? Maybe I am missing the exact context.
I ran tox with and without this change. After clearing local cache both times I don't see any specific speedups.
With the new URL:
1st run: 44 passed in 370.73s
2nd run: 44 passed in 10.79s
With the old URL:
1st run: 44 passed in 372.07s
2nd run: 44 passed in 10.89s

@jokasimr
Copy link
Contributor Author

jokasimr commented Mar 4, 2025

What are we optimising here for btw? Maybe I am missing the exact context.

We're optimizing for the total time to run the tests when the pooch cache is empty. So from what you wrote it seems to me like we're on the same page.

But the results you show are unexpected, it looks like the local pooch cache is not cleared, are you sure it is?

(I think you already did this, but just to clarify, the pooch cache need to be cleared in between every run.)

@MridulS
Copy link
Member

MridulS commented Mar 4, 2025

(I think you already did this, but just to clarify, the pooch cache need to be cleared in between every run.)

I did not!! The change makes sense now!

@jokasimr
Copy link
Contributor Author

jokasimr commented Mar 4, 2025

I'm not 100% sure this is stable yet, we had the network error earlier for example.
But if we try it out for a while we will find out, so I'll merge it anyway and if it breaks we can change the url back again.

@jokasimr jokasimr merged commit 0a03844 into main Mar 4, 2025
5 checks passed
@jokasimr jokasimr deleted the test-cache branch March 4, 2025 12:25
@jokasimr
Copy link
Contributor Author

jokasimr commented Mar 4, 2025

For the record the caching code is here: https://github.com/scipp/fileserver-cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants