Add basic TBL workflow for reading and transforming data to tof/wavelength #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
reviewed
Apr 2, 2025
| ```{button-ref} user-guide/odin/odin_simulation | ||
| :class: stretched-link | ||
| ODIN McStas Simulation - Timepix Simulation with Choppers |
Member
There was a problem hiding this comment.
Should we have TBL card as well?
Member
Author
There was a problem hiding this comment.
No need for now, I have a plan to restructure all the docs, with cards for instruments etc...
YooSunYoung
reviewed
Apr 2, 2025
Co-authored-by: Sunyoung Yoo <luysunyoung9@gmail.com>
YooSunYoung
reviewed
Apr 2, 2025
| "\n", | ||
| "for bank in ('he3_detector_bank0', 'he3_detector_bank1'):\n", | ||
| " he3_wf[NeXusDetectorName] = bank\n", | ||
| " he3_tofs[bank] = he3_wf.compute(TofData[SampleRun]).bins.concat().hist(tof=200)\n", |
Member
There was a problem hiding this comment.
(Minor)
Should we decrease tof bin edges since it's just on a small dataset for documentation...?
It'll look prettier : D...
YooSunYoung
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add basic TBL workflow for reading and transforming data to tof/wavelength.
We also structured the docs into subfolders for odin, ymir and tbl.