fix: set variances of McStas data #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YooSunYoung
reviewed
Mar 31, 2025
| ) | ||
| da = sc.DataArray( | ||
| data=counts.copy().astype(sc.DType.int32), | ||
| data=counts.copy(), |
Member
There was a problem hiding this comment.
Why did you remove astype to int...?
Contributor
Author
There was a problem hiding this comment.
Because the integer dtype can't have variances for some reason 🤷 (scipp raises an error)
Is it important that the weights are integers?
Member
There was a problem hiding this comment.
Integer counts make some operations faster but where doesn't like integer anyways so maybe it's fine...?
YooSunYoung
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix set variances of McStas simulation data to square of event weights.