Clean up mcstas example notebook. #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvaytet
reviewed
Feb 26, 2025
| @@ -0,0 +1,343 @@ | |||
| # SPDX-License-Identifier: BSD-3-Clause | |||
Member
There was a problem hiding this comment.
Was this PR just about moving code around, or is a closer look required?
Member
Author
There was a problem hiding this comment.
Yes, it is just about moving code around : D...!
or is a closer look required?
So not really
nvaytet
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notebook had too many helper functions included so I just moved them to a separate module for now.
Not refactoring it as a package module since we're expecting more changes from mcstas side still.
But, we need to keep the notebook clean because this notebook is for the STAP demo.