Odin simulation workflow loader and hardcoded choppers. #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35641c5 to
3373436
Compare
48e5ddd to
fbcd34f
Compare
abc9270 to
d79d60c
Compare
0c1ae84 to
c65afcc
Compare
d79d60c to
d919f67
Compare
(cherry picked from commit 280da3c341cf0d8bf0b7a46a51586b564da33b72)
d919f67 to
b18fc87
Compare
nvaytet
reviewed
Nov 27, 2024
| " .values\n", | ||
| " )\n", | ||
| " return sc.vectors(dims=['event'], values=var, unit='m')\n" | ||
| ] |
Member
There was a problem hiding this comment.
I feel that most of the code at the start of this notebook should be part of a submodule in the package, and not in the notebook?
Member
Author
There was a problem hiding this comment.
Yeah, as Søren wanted everything before December,
I thought we don't have time to make them as a module, write test and documentation.
Also, McStas format is not stable at the moment so I didn't want to start working on a mcstas IO module...
| " return RectInfo(x_range.min(), x_range.max(), y_range.min(), y_range.max())\n", | ||
| "\n", | ||
| "\n", | ||
| "class MergedRectanglesTool(ToggleTool):\n", |
Member
There was a problem hiding this comment.
I also think this code should go in a submodule, so we can just simply import the tool in the notebook?
Member
Author
There was a problem hiding this comment.
Yeah. Then I'll do that in plopp maybe...?
nvaytet
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #20, #26 and Related to one of milestone for p6
The notebook is for P6 milestone report so it is expected to be refactored and integrated into a module as a reusable workflow.
#56 should be merged first.