-
Notifications
You must be signed in to change notification settings - Fork 1
Saturation indicator #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saturation indicator #106
Conversation
|
The implementation here
Is this algorithm sufficient? Is this the interface we need? Is there any test data (beside the example posted in the issue)? |
I think so...?
We should probably have a visualization tool too. (i.e. notebook in code shelf)
Unfortunately not. But it will be needed from the day 1 of hot-comissioning. |
What kind of visualization do you have in mind? |
Yes...! So... maybe the final interface for user(instrument scientist), including visualization can be written later from here...? |
That can be fixed. 👍 I just scheduled a meeting with Soren this afternoon to talk about what interface he needs. |
docs/tools/index.md
Outdated
| sharpness-and-focus-point | ||
| maximum_resolution_achievable | ||
| saturation_indicator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the notebook called saturation_indicator missing...?
And maximum_resolution_achievable is also missing from the menu: https://remote-unzip.deno.dev/scipp/essimaging/artifacts/3961599931/tools/index.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍 added those by mistake.
| "laplace_2d", | ||
| "maximum_resolution_achievable", | ||
| "resample", | ||
| "saturation_indicator", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API reference doesn't seem to be rendered properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange, might be because of some white space in the docs comment.
I'll try to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I'm not sure why the api reference is not rendered properly here. Do you know @YooSunYoung ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I missed the comment. It looks like you fixed it though : D ...!
| "laplace_2d", | ||
| "maximum_resolution_achievable", | ||
| "resample", | ||
| "saturation_indicator", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I missed the comment. It looks like you fixed it though : D ...!






Fixes #24
Not sure if this is actually the tool that is requested, or if the approach does what we need, but I think it's good to have a starting point for discussion.